lkml.org 
[lkml]   [1997]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject2.1.23: bug in kernel/module.c (patch included)

Hi Kernel Hackers -

I found a bug in 2.1.23 today that was giving me a null pointer oops any
time I tried to load a module after I loaded ipv6. I tracked it down to
some code in kernel/module.c that was traversing the symbol
list but incrementing a pointer twice. I imagine it was just an
oversight.

It looks like the code only gets called when the symbol table for a module
is large, so it was only tickled by ipv6's symbols.

This bug may be present in earlier/other versions as well?

Here's the patch:

--- kernel/module.c.orig Mon Jan 27 09:18:04 1997
+++ kernel/module.c Mon Jan 27 14:32:59 1997
@@ -583,7 +583,7 @@

calc_space_needed:
for (; i < mod->nsyms; ++i, ++s)
- space += strlen((++s)->name)+1;
+ space += strlen(s->name)+1;

if (put_user(space, ret))
return -EFAULT;

--
John Callahan <jcallaha@willamette.edu> |Assistant Director, Network Services
Willamette Integrated Technology Services|Willamette University, Salem, OR, USA
Phone: (503) 375-5495 Fax: (503) 375-5456|http://www.willamette.edu/~jcallaha

\
 
 \ /
  Last update: 2005-03-22 13:38    [W:0.031 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site