| Date | Wed, 3 Apr 2024 12:36:11 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 16/34] iio: ad5755: hook up of_device_id lookup to platform driver |
| |
On Wed, Apr 03, 2024 at 10:06:34AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When the driver is built-in, 'make W=1' warns about an unused > ID table: > > drivers/iio/dac/ad5755.c:866:34: error: 'ad5755_of_match' defined but not used [-Werror=unused-const-variable=] > 866 | static const struct of_device_id ad5755_of_match[] = { > > While the data is duplicated in the spi_device_id, it's common > to use the actual OF compatible strings in the driver. > > Since there are no in-tree users of plain platform devices, the > spi_device_id table could actually be dropped entirely with this.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-- With Best Regards, Andy Shevchenko
|