Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 10/34] efi: sysfb: don't build when EFI is disabled | Date | Wed, 03 Apr 2024 15:15:48 +0200 |
| |
Ard Biesheuvel <ardb@kernel.org> writes:
> On Wed, 3 Apr 2024 at 11:09, Arnd Bergmann <arnd@kernel.org> wrote: >> >> From: Arnd Bergmann <arnd@arndb.de> >> >> With 'make W=1', there is a warning when EFI is turned off but sysfb_efi >> still gets built: >> >> drivers/firmware/efi/sysfb_efi.c:188:35: error: unused variable 'efifb_dmi_system_table' [-Werror,-Wunused-const-variable] >> static const struct dmi_system_id efifb_dmi_system_table[] __initconst = { >> ^ >> drivers/firmware/efi/sysfb_efi.c:238:35: error: unused variable 'efifb_dmi_swap_width_height' [-Werror,-Wunused-const-variable] >> static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = { >> ^ >> drivers/firmware/efi/sysfb_efi.c:297:28: error: unused function 'find_pci_overlap_node' [-Werror,-Wunused-function] >> static struct device_node *find_pci_overlap_node(void) >> >> There was an earlier patch to address the duplicate function definitions, but >> that missed how we should not be building this file in the first place. >> >> Fixes: 15d27b15de96 ("efi: sysfb_efi: fix build when EFI is not set") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Ard Biesheuvel <ardb@kernel.org> >
Looks good to me too.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
> or I can take it via the EFI tree if you prefer. >
I think that could be merged through your EFI tree. Thanks!
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |