Messages in this thread | | | Date | Wed, 7 Jun 2023 21:58:27 -0700 | Subject | Re: [v6 2/4] dt-bindings: hwmon: Add ASPEED TACH Control documentation | From | Guenter Roeck <> |
| |
On 6/7/23 19:18, Billy Tsai wrote: > Document the compatible for aspeed,ast2600-tach device. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- > .../bindings/hwmon/aspeed,ast2600-tach.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > new file mode 100644 > index 000000000000..627aa00f2e92 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2021 Aspeed, Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/aspeed,ast2600-tach.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed Ast2600 Tach controller > + > +maintainers: > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +description: | > + The Aspeed Tach controller can support upto 1 fan input. > +
The code says:
In Aspeed AST2600 SoC features 16 TACH controllers, with each controller capable of supporting up to 1 input.
which is a bit different. I guess there are no examples anymore, but I'd really like to see how this looks like in the devicetree file, and how the driver is supposed to distinguish/select the 16 inputs.
> +properties: > + compatible: > + enum: > + - aspeed,ast2600-tach > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - clocks > + - resets > + > +additionalProperties: false
| |