Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 29 Mar 2023 10:44:34 +0200 | Subject | Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits |
| |
On Thu, Mar 23, 2023 at 9:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
> If the "ngpios" property is specified, bgpio_bits is calculated > as the round up value of ngpio. At the moment, the only requirement > specified is that the round up value must be a multiple of 8 but > it should also be a power of 2 because we provide accessors based > on the bank size in bgpio_setup_accessors(). > > Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
Neat fixup, Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |