Messages in this thread | | | From | Asmaa Mnebhi <> | Subject | RE: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits | Date | Fri, 24 Mar 2023 13:43:38 +0000 |
| |
> > > > > > If the "ngpios" property is specified, bgpio_bits is calculated as > > > the round up value of ngpio. At the moment, the only requirement > > > specified is that the round up value must be a multiple of 8 but it > > > should also be a power of 2 because we provide accessors based on > > > the bank size in bgpio_setup_accessors(). > > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Btw, I do not see the initial patch in Bart's tree. I suppose you may simply > send a v5 of the original one with this fix applied inplace. > Yes I was not able to find it on any branch yet so I just sent this patch based the other one.
| |