Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 24 Mar 2023 14:09:28 +0200 | Subject | Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits |
| |
On Fri, Mar 24, 2023 at 2:07 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote: > > > > If the "ngpios" property is specified, bgpio_bits is calculated > > as the round up value of ngpio. At the moment, the only requirement > > specified is that the round up value must be a multiple of 8 but > > it should also be a power of 2 because we provide accessors based > > on the bank size in bgpio_setup_accessors(). > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Btw, I do not see the initial patch in Bart's tree. I suppose you may simply send a v5 of the original one with this fix applied inplace.
-- With Best Regards, Andy Shevchenko
| |