Messages in this thread | | | Date | Fri, 27 Oct 2023 08:50:45 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2] seq_buf: Introduce DECLARE_SEQ_BUF and seq_buf_str() |
| |
On Fri, Oct 27, 2023 at 06:54:51AM +0200, Christoph Hellwig wrote: > On Thu, Oct 26, 2023 at 12:40:37PM -0700, Kees Cook wrote: > > Solve two ergonomic issues with struct seq_buf; > > > > 1) Too much boilerplate is required to initialize: > > > > struct seq_buf s; > > char buf[32]; > > > > seq_buf_init(s, buf, sizeof(buf)); > > > > Instead, we can build this directly on the stack. Provide > > DECLARE_SEQ_BUF() macro to do this: > > > > DECLARE_SEQ_BUF(s, 32); > > DECLARE_SEQ_BUF_ONSTACK maybe? But otherwise this looks like a good > concept.
It's usable for globals too... also it's a shorter name as-is. :)
-- Kees Cook
| |