Messages in this thread | | | Date | Fri, 27 Oct 2023 08:46:16 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2] seq_buf: Introduce DECLARE_SEQ_BUF and seq_buf_str() |
| |
On Thu, Oct 26, 2023 at 03:44:59PM -0400, Steven Rostedt wrote: > On Thu, 26 Oct 2023 12:40:37 -0700 > Kees Cook <keescook@chromium.org> wrote: > > > @@ -81,16 +88,20 @@ static inline unsigned int seq_buf_used(struct seq_buf *s) > > * > > * After this function is called, s->buffer is safe to use > > * in string operations. > > + * > > + * Returns @s->buf after making sure it is terminated. > > */ > > -static inline void seq_buf_terminate(struct seq_buf *s) > > +static inline char *seq_buf_str(struct seq_buf *s) > > Looking at show_buffer() (below), I wonder if this should be: > > static inline const char *seq_buf_str() ? > > I mean, it can be modified, but do we want to allow that?
Yeah, good idea. I've updated this for v3.
-- Kees Cook
| |