Messages in this thread | | | Date | Fri, 27 Oct 2023 11:53:32 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2] seq_buf: Introduce DECLARE_SEQ_BUF and seq_buf_str() |
| |
On Fri, Oct 27, 2023 at 06:54:51AM +0200, Christoph Hellwig wrote: > > Instead, we can just return s->buffer direction after terminating it > > in refactored seq_buf_terminate(), now known as seq_buf_str(): > > > > do_soemthing(seq_buf_str(s)); > > Looks good. Btw, one typical do_something would be printing it, > so adding a format specifier that's using this helper would also > probably be very useful.
my hope is to get vsprintf.c completely refactored to use seq_buf internally, and then printsb(&sb) would actually be a primitive we'd have insted of printk("%pSB", &sb);
this would btw let us get rid of the entire %pFOO infrastructure. and make dump_page() far less crap.
| |