Messages in this thread | ![/](/images/icornerl.gif) | | From | "G, GurucharanX" <> | Subject | RE: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant pci_enable_pcie_error_reporting() | Date | Wed, 25 Jan 2023 10:34:06 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Bjorn Helgaas > Sent: Thursday, January 19, 2023 5:16 AM > To: linux-pci@vger.kernel.org > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg, > Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjorn > Helgaas <bhelgaas@google.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com> > Subject: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant > pci_enable_pcie_error_reporting() > > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this doesn't control interrupt generation by the Root Port; that is > controlled by the AER Root Error Command register, which is managed by the > AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ---- > 1 file changed, 4 deletions(-) >
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
| ![\](/images/icornerr.gif) |