lkml.org 
[lkml]   [2023]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant pci_enable_pcie_error_reporting()
    Date


    > -----Original Message-----
    > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
    > Bjorn Helgaas
    > Sent: Thursday, January 19, 2023 5:16 AM
    > To: linux-pci@vger.kernel.org
    > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
    > Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjorn
    > Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
    > <anthony.l.nguyen@intel.com>
    > Subject: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
    > pci_enable_pcie_error_reporting()
    >
    > From: Bjorn Helgaas <bhelgaas@google.com>
    >
    > pci_enable_pcie_error_reporting() enables the device to send ERR_*
    > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
    > native"), the PCI core does this for all devices during enumeration.
    >
    > Remove the redundant pci_enable_pcie_error_reporting() call from the
    > driver. Also remove the corresponding pci_disable_pcie_error_reporting()
    > from the driver .remove() path.
    >
    > Note that this doesn't control interrupt generation by the Root Port; that is
    > controlled by the AER Root Error Command register, which is managed by the
    > AER service driver.
    >
    > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
    > Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
    > Cc: intel-wired-lan@lists.osuosl.org
    > Cc: netdev@vger.kernel.org
    > ---
    > drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
    > 1 file changed, 5 deletions(-)
    >

    Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)

    \
     
     \ /
      Last update: 2023-03-26 23:55    [W:6.138 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site