Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 20 Jan 2023 07:14:19 -0600 | From | Bjorn Helgaas <> | Subject | Re: [Intel-wired-lan] [PATCH 2/9] e1000e: Remove redundant pci_enable_pcie_error_reporting() |
| |
On Thu, Jan 19, 2023 at 07:17:35PM -0800, Jakub Kicinski wrote: > On Wed, 18 Jan 2023 17:46:05 -0600 Bjorn Helgaas wrote: > > From: Bjorn Helgaas <bhelgaas@google.com> > > > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > > native"), the PCI core does this for all devices during enumeration. > > > > Remove the redundant pci_enable_pcie_error_reporting() call from the > > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > > from the driver .remove() path. > > > > Note that this doesn't control interrupt generation by the Root Port; that > > is controlled by the AER Root Error Command register, which is managed by > > the AER service driver. > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > How would you like to route these? Looks like there's no dependency > so we can pick them up?
Right, no dependencies, so you can pick them up. Sounds like you and Tony have it worked out. Thanks!
Bjorn
| ![\](/images/icornerr.gif) |