lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Static analysis is warning that the sizeof being used is should be
    of *vport and not vport. Although these are the same size it is not
    a portable assumption to assume this is true for all cases. Fix this
    by using sizeof(*vport).

    Addresses-Coverity: ("Sizeof not portable")
    Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    sound/isa/sc6000.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
    index 6236c4fa766a..44c05b55fc15 100644
    --- a/sound/isa/sc6000.c
    +++ b/sound/isa/sc6000.c
    @@ -552,7 +552,7 @@ static int snd_sc6000_probe(struct device *devptr, unsigned int dev)


    err = snd_devm_card_new(devptr, index[dev], id[dev], THIS_MODULE,
    - sizeof(vport), &card);
    + sizeof(*vport), &card);
    if (err < 0)
    return err;

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-07-20 18:25    [W:6.749 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site