lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] ALSA: sc6000: Fix incorrect sizeof operator
On Tue, 20 Jul 2021 18:17:07 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis is warning that the sizeof being used is should be
> of *vport and not vport. Although these are the same size it is not
> a portable assumption to assume this is true for all cases. Fix this
> by using sizeof(*vport).
>
> Addresses-Coverity: ("Sizeof not portable")
> Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks. I have another patch to drop this allocation (it's just a
pointer, so no need for kmalloc, really), but since your patch is
correct, I'll rebase on yours.


Takashi

\
 
 \ /
  Last update: 2021-07-20 18:32    [W:0.029 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site