Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | cgel.zte@gmail ... | Subject | [PATCH] sched/fair: fix boolreturn.cocci warning | Date | Tue, 14 Dec 2021 11:38:45 +0000 |
| |
From: Changcheng Deng <deng.changcheng@zte.com.cn>
./kernel/sched/fair.c: 9781: 9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool
Return statements in functions returning bool should use true/false instead of 1/0.
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ac5e55441cab..0e62fd7ac0e6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9778,9 +9778,9 @@ imbalanced_active_balance(struct lb_env *env) */ if ((env->migration_type == migrate_task) && (sd->nr_balance_failed > sd->cache_nice_tries+2)) - return 1; + return true; - return 0; + return false; } static int need_active_balance(struct lb_env *env) -- 2.25.1
| ![\](/images/icornerr.gif) |