Messages in this thread Patch in this message | | | Date | Tue, 14 Dec 2021 09:14:46 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] sched/fair: fix boolreturn.cocci warning |
| |
I'll save Peter Zijlstra time from replying to this.
On Tue, 14 Dec 2021 11:38:45 +0000 cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn> > > ./kernel/sched/fair.c: 9781: 9-10: WARNING: return of 0/1 in function > 'imbalanced_active_balance' with return type bool > > Return statements in functions returning bool should use true/false > instead of 1/0.
This is a stupid warning. In C "1" is the same as "true" and "0" is the same as "false".
This is a bogus error message and something not needed to be fixed.
Please remove these checks from your scripts.
NACK
-- Steve
> > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > --- > kernel/sched/fair.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ac5e55441cab..0e62fd7ac0e6 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -9778,9 +9778,9 @@ imbalanced_active_balance(struct lb_env *env) > */ > if ((env->migration_type == migrate_task) && > (sd->nr_balance_failed > sd->cache_nice_tries+2)) > - return 1; > + return true; > > - return 0; > + return false; > } > > static int need_active_balance(struct lb_env *env)
| |