lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] Add LED mode behavior/select properties and handle
Date
In KSZ9131 PHY it is possible to control LEDs blink behavior via
LED mode behavior and select registers. Add DTS properties plus handles
of them inside micrel PHY driver.

I've some concerns about passing raw register values into LED mode
select and behavior. It can be passed via array like in microchip
driver(Documentation/devicetree/bindings/net/microchip,lan78xx.txt).
There is the problem in this particular driver - there is a lot of other PHYs
and led mode behavior/select states may intersect, that's the reason why
I did it this way. Is there any good ways to make it look more properly?

Ivan Mikhaylov (2):
net: phy: micrel: add LED control on KSZ9131
dt-bindings: net: phy: micrel: add LED mode behavior and select
properties

.../devicetree/bindings/net/micrel.txt | 7 ++
drivers/net/phy/micrel.c | 69 ++++++++++++++++++-
2 files changed, 75 insertions(+), 1 deletion(-)

--
2.21.1

\
 
 \ /
  Last update: 2020-12-09 15:02    [W:0.054 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site