Messages in this thread Patch in this message | | | From | Nicholas Mc Guire <> | Subject | [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data | Date | Fri, 7 Dec 2018 09:22:43 +0100 |
| |
devm_kstrdup() may return NULL if internal allocation failed, but as machine is from the device tree, and thus RO, devm_kstrdup_const() can be used here, which will only copy the reference.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: a6fc3b698130 ("soc: fsl: add GUTS driver for QorIQ platforms") ---
Problem located by experimental coccinelle script
Patch was compile tested with: multi_v7_defconfig (implies FSL_GUTS=y)
Patch is against 4.20-rc5 (localversion-next is next-20181207)
drivers/soc/fsl/guts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 302e0c8..15071ec 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc/fsl/guts.c @@ -157,7 +157,8 @@ static int fsl_guts_probe(struct platform_device *pdev) of_property_read_string_index(root, "compatible", 0, &machine); of_node_put(root); if (machine) - soc_dev_attr.machine = devm_kstrdup(dev, machine, GFP_KERNEL); + soc_dev_attr.machine = devm_kstrdup_const(dev, machine, + GFP_KERNEL); svr = fsl_guts_get_svr(); soc_die = fsl_soc_die_match(svr, fsl_soc_die); -- 2.1.4
| |