Messages in this thread | ![/](/images/icornerl.gif) | | From | Scott Wood <> | Date | Fri, 21 Dec 2018 20:29:56 -0600 | Subject | Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data |
| |
On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > devm_kstrdup() may return NULL if internal allocation failed, but > as machine is from the device tree, and thus RO, devm_kstrdup_const() > can be used here, which will only copy the reference.
Is it really going to only copy the reference? That would require that is_kernel_rodata(machine) be true, which it shouldn't be since it's not part of the kernel image.
-Scott
| ![\](/images/icornerr.gif) |