| From | Andy Shevchenko <> | Date | Thu, 18 May 2017 19:49:21 +0300 | Subject | Re: [PATCH 07/24] thunderbolt: Convert switch to a device |
| |
On Thu, May 18, 2017 at 5:38 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > Thunderbolt domain consists of switches that are connected to each > other, forming a bus. This will convert each switch into a real Linux > device structure and adds them to the domain. The advantage here is > that we get all the goodies from the driver core, like reference > counting and sysfs hierarchy for free. > > Also expose device identification information to the userspace via new > sysfs attributes. > > In order to support internal connection manager (ICM) we separate switch > configuration into its own function (tb_switch_configure()) which is > only called by the existing native connection manager implementation > used on Macs. >
Couple of nits below.
> + > + return sw; > +err:
Perhaps err_free_sw_ports: ?
> + kfree(sw->ports); > + kfree(sw); > + return NULL; > +}
> + /* upload configuration */ > + ret = tb_sw_write(sw, 1 + (u32 *) &sw->config, TB_CFG_SWITCH, 1, 3);
Extra space before &.
> + if (ret) > + return ret;
-- With Best Regards, Andy Shevchenko
|