| From | Arnd Bergmann <> | Date | Mon, 27 Nov 2017 15:30:16 +0100 | Subject | Re: [PATCH v2 22/35] nds32: Device tree support |
| |
On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <green.hu@gmail.com> wrote: > @@ -0,0 +1,55 @@ > +/dts-v1/; > +/ { > + compatible = "nds32 ae3xx";
The compatible string doesn't seem to match the binding, it should always have vendor prefix.
> + #address-cells = <1>; > + #size-cells = <1>; > + interrupt-parent = <&intc>; > + > + chosen { > + bootargs = "earlycon console=ttyS0,38400n8 debug loglevel=7"; > + stdout-path = &serial0; > + };
I would drop the bootargs here, this is something that should be set by the bootloader and is up to the user.
Arnd
|