lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 22/35] nds32: Device tree support
    2017-11-27 22:30 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
    > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <green.hu@gmail.com> wrote:
    >> @@ -0,0 +1,55 @@
    >> +/dts-v1/;
    >> +/ {
    >> + compatible = "nds32 ae3xx";
    >
    > The compatible string doesn't seem to match the binding, it should always have
    > vendor prefix.

    Sorry I forgot to check this.
    I will provide a document in bindings like
    "Documentation/devicetree/bindings/nds32/andestech-boards".


    >> + #address-cells = <1>;
    >> + #size-cells = <1>;
    >> + interrupt-parent = <&intc>;
    >> +
    >> + chosen {
    >> + bootargs = "earlycon console=ttyS0,38400n8 debug loglevel=7";
    >> + stdout-path = &serial0;
    >> + };
    >
    > I would drop the bootargs here, this is something that should be set by the
    > bootloader and is up to the user.

    Thanks
    I will drop it in the next version patch.

    \
     
     \ /
      Last update: 2017-11-28 07:56    [W:2.282 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site