| Subject | Re: [PATCH v2 33/35] clocksource/drivers/atcpit100: Add andestech atcpit100 timer | From | Daniel Lezcano <> | Date | Thu, 7 Dec 2017 09:44:55 +0100 |
| |
On 27/11/2017 13:28, Greentime Hu wrote: > From: Rick Chen <rickchen36@gmail.com> > > ATCPIT100 is often used on the Andes architecture, > This timer provide 4 PIT channels. Each PIT channel is a > multi-function timer, can be configured as 32,16,8 bit timers > or PWM as well. > > For system timer it will set channel 1 32-bit timer0 as clock > source and count downwards until underflow and restart again. > > It also set channel 0 32-bit timer0 as clock event and count > downwards until condition match. It will generate an interrupt > for handling periodically. > > Signed-off-by: Rick Chen <rickchen36@gmail.com> > Signed-off-by: Greentime Hu <green.hu@gmail.com> > ---
Looks good.
Please resend this patch folded with the Makefile change and the DT binding (fixed) as suggested by Arnd. I will merge them.
Thanks
-- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
|