Messages in this thread Patch in this message | | | From | Hans de Goede <> | Subject | [PATCH] extcon: Fix attached value returned by is_extcon_changed | Date | Mon, 24 Aug 2015 00:35:36 +0200 |
| |
is_extcon_changed should only check the idx-th bit of new, not the entirety of new when setting attached.
This fixes extcon sending notifications that a cable was inserted when it gets removed while another cable is still connected.
Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/extcon/extcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 43b57b0..c4698ce 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -159,7 +159,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached) { if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) { - *attached = new ? true : false; + *attached = ((new >> idx) & 0x1) ? true : false; return true; } -- 2.4.3
| |