lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] extcon: Fix attached value returned by is_extcon_changed
On 2015년 08월 24일 07:35, Hans de Goede wrote:
> is_extcon_changed should only check the idx-th bit of new, not
> the entirety of new when setting attached.
>
> This fixes extcon sending notifications that a cable was inserted when
> it gets removed while another cable is still connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 43b57b0..c4698ce 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -159,7 +159,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
> static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached)
> {
> if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) {
> - *attached = new ? true : false;
> + *attached = ((new >> idx) & 0x1) ? true : false;
> return true;
> }
>
>

Applied it.

Thanks,
Chanwoo Choi


\
 
 \ /
  Last update: 2015-09-03 09:21    [W:0.038 / U:6.680 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site