Messages in this thread | | | From | Andy Lutomirski <> | Date | Fri, 6 Jun 2014 14:22:12 -0700 | Subject | Re: [GIT PULL] x86/vdso changes for v3.16 |
| |
On Fri, Jun 6, 2014 at 2:15 PM, H. Peter Anvin <hpa@linux.intel.com> wrote: > On 06/06/2014 02:13 PM, Linus Torvalds wrote: >> On Fri, Jun 6, 2014 at 2:09 PM, Andy Lutomirski <luto@amacapital.net> wrote: >>> >>> The only real downside to that would be the chance of bitrot if that >>> code isn't getting used on native builds. >> >> Sure. Does anybody really care? >> >> You could obviously just open-code the things, but the fact is, >> "le64toh()" isn't exactly a standard function anyway, so now that I >> see it needed I go "yeah, that's clearly completely unacceptable". >> >> I'd much rather say "screw cross-compiling" (because let's face it, >> nobody sane cross-compiles x86 on anything else) than say "screw old >> machines". >> > > I'm thinking we should just carry the support functions with us, we > already have some of those in tools/include. Working on a patchset for > this.
Sounds good.
In the mean time, a trivial fix is here:
https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=vdso/cleanup_fixes&id=cf780a0dc71f7cbd9a417e6ce2d5ddf56abccb74
(or it will be once the mirrors sync)
--Andy
| |