Messages in this thread | | | Date | Fri, 06 Jun 2014 14:07:11 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [GIT PULL] x86/vdso changes for v3.16 |
| |
On 06/06/2014 02:00 PM, Andrew Morton wrote: > On Wed, 4 Jun 2014 15:35:42 -0700 "H. Peter Anvin" <hpa@linux.intel.com> wrote: > >> Vdso cleanups and improvements largely from Andy Lutomirski. > > arch/x86/vdso/vdso2c.h: In function 'go64': > arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh' > arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh' > arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh' > arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16' > > My Fedora Core 6 (lol gotcha) test box doesn't have these. > > http://www.unix.com/man-page/linux/3/le64toh/ has some details. I > don't appear to have letoh64 and friends either. >
OK... so now we have a tools baseline problem. It isn't that we couldn't open-code these functions, but of course we'd also like to not *have* to do so... but also we don't want to have the kernel build rely on autoconf ;)
So we have a few options, here:
1. We could use the unaligned macros defined in tools/include/tools/*_byteshift.h.
2. Open-code it.
3. Define a baseline which includes these kinds of functions.
I guess I would be leaning toward #1, but would also wonder if that also means we should add -I$(srctree)/tools/include to the global settings ... we are *already* adding it to HOSTCFLAGS_sortextable.o.
Thoughs?
-hpa
| |