Messages in this thread | | | From | Andy Lutomirski <> | Date | Fri, 6 Jun 2014 14:09:54 -0700 | Subject | Re: [GIT PULL] x86/vdso changes for v3.16 |
| |
On Fri, Jun 6, 2014 at 2:07 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Fri, Jun 6, 2014 at 2:00 PM, Andrew Morton <akpm@linux-foundation.org> wrote: >> >> arch/x86/vdso/vdso2c.h: In function 'go64': >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh' >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh' >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh' >> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16' >> >> My Fedora Core 6 (lol gotcha) test box doesn't have these. > > Suggested fix: only use the helper functions on non-x86 (or > non-little-endian) platforms. > > Peter, Andy?
The only real downside to that would be the chance of bitrot if that code isn't getting used on native builds.
Blech.
--Andy
| |