Messages in this thread | | | Date | Tue, 29 Apr 2014 18:02:26 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: line6: fix possible overrun |
| |
Yeah. If this were a brand new driver then returning -EINVAL would be a good idea.
Smatch actually warns about this code as well if you turn on the --spammy option. But there are too many of these kinds of warnings and even I can't check them all so the warning is basically useless.
In a few months I will have improved the Smatch code to know that the source string is too large so this bug could have been avoided.
regards, dan carpenter
| |