lkml.org 
[lkml]   [2014]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: line6: fix possible overrun
At Mon, 28 Apr 2014 01:44:25 +0300,
Dan Carpenter wrote:
>
> On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
> > > > and a WARN_ON + -EINVAL in line6_init_audio to catch future
> > > > offenders.
> > >
> > > Returning -EINVAL is a bad idea because it would break the driver
> > > completely and make it unusable.
> > >
> >
> > Well I would vote for returning the error anyway.
>
> I'm trying to be polite, but you are talking about adding regressions
> deliberately...
>
> It's very rare for people to deliberately add regressions to the kernel.
> I have only seen it one time before.

I don't think Dan would be against returning -EINVAL if all the
offender codes have been fixed (e.g. truncating strings to fit with
the fixed arrays) at first. Then it'd be a good help to catch any
future bugs. But, having -EINVAL without fixing the caller side means
essentially that you're introducing the breakage intentionally
although you know it certainly breaks, which is obviously bad.


Takashi


\
 
 \ /
  Last update: 2014-04-29 18:21    [W:0.063 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site