Messages in this thread | | | Date | Sun, 27 Apr 2014 20:39:32 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: line6: fix possible overrun |
| |
On Sat, Apr 26, 2014 at 11:59:46PM +0200, Mateusz Guzik wrote: > > And sadly enough some of those ->id strings are more than 15 characters > > and a NUL which will fit in card->id. So this overflow is real. The > > card->shortname is a 32 char array so none of those overflow. > > > > If we want to sovle the truncation issue then we need to think of > > shorter names for BassPODxtLive, BassPODxtPro, PODStudioUX1, and > > PODStudioUX2. > > > > In that case I suggest compile time assertions that ids and names fit
That sounds like some magic code which I would love to see. :)
> and a WARN_ON + -EINVAL in line6_init_audio to catch future > offenders.
Returning -EINVAL is a bad idea because it would break the driver completely and make it unusable.
> > As a side note I'm not sure if pod_try_init from drivers/staging/line6/pod.c > cleans up properly after failed line6_init_audio.
Yeah. It doesn't seem to clean up at all.
regards, dan carpenter
| |