Messages in this thread | | | From | "Marciniszyn, Mike" <> | Subject | RE: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code | Date | Mon, 9 Sep 2013 14:55:46 +0000 |
| |
> Subject: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify > code > > Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and > pcie_get_mps() to simply code. Because pci core caches the "PCI-E Max > Payload Size Supported" in pci_dev->pcie_mpss, so use that instead of > pcie_capability_read_word(). Remove the unused val2fld() and fld2val(). >
I tested this patch as is and saw no issues.
The only thing I would suggest is that the new use of pcie_get_readrq/pcie_set_readrq() be reflected in the comments with an appropriate adjustment in the subject.
Mike
| |