Messages in this thread | | | From | Bjorn Helgaas <> | Date | Fri, 4 Oct 2013 14:49:39 -0600 | Subject | Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code |
| |
On Mon, Sep 30, 2013 at 8:56 AM, Marciniszyn, Mike <mike.marciniszyn@intel.com> wrote: >> >> Is something like the following what you had in mind? If so, I can >> just queue it up. Otherwise, I'll wait for Yijing to post a v2 patch. >> >> >> IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code >> >> From: Yijing Wang <wangyijing@huawei.com> >> >> Refactor qib_tune_pcie_caps(). Use pcie_get_mps(), pcie_set_mps(), >> pcie_get_readrq(), and pcie_set_readrq() to simplify the code. The PCI >> core caches the "PCIe Max Payload Size Supported" in pci_dev->pcie_mpss, >> so use that instead of pcie_capability_read_word(). Remove the unused >> val2fld() and fld2val(). >> >> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > This works! > > Go ahead and queue it up.
Applied to my pci/yijing-mps-v1 branch with your ack:
http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/yijing-mps-v1&id=0ce0e62f1f7893f983a8f61bc8f5306e80d520b1
Let me know if that's not what you had in mind. Thanks!
Bjorn
| |