Messages in this thread | | | Date | Mon, 23 Sep 2013 21:20:37 +0200 | Subject | Re: [PATCH 5/9] of/irq: Introduce __of_irq_to_resource() | From | Linus Walleij <> |
| |
On Mon, Sep 16, 2013 at 11:29 PM, Rob Herring <robherring2@gmail.com> wrote: > On 09/16/2013 03:32 AM, Thierry Reding wrote: >> This is a version of of_irq_to_resource() that propagates the precise >> error code instead of returning 0 for all errors. It will be used in >> subsequent patches to allow further propagation of error codes. >> >> To avoid code duplication, implement of_irq_to_resource() as a wrapper >> around the new __of_irq_to_resource(). > > I think the callers in this case are manageable to update as well. > Several cases could simply use irq_of_parse_and_map instead as they just > pass in a NULL resource.
I second this comment.
Yours, Linus Walleij
| |