Messages in this thread | | | Date | Mon, 23 Sep 2013 21:18:52 +0200 | Subject | Re: [PATCH 4/9] of/irq: Introduce of_irq_get() | From | Linus Walleij <> |
| |
On Tue, Sep 17, 2013 at 3:28 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > On Mon, Sep 16, 2013 at 04:24:47PM -0500, Rob Herring wrote:
>> *_get typically also implies some reference counting which I don't >> believe this does. I don't think having 2 functions with completely >> different names doing the same thing with only a different calling >> convention is good either. So I would keep the old name and the names >> aligned. > > Okay, I'll make the new function __irq_of_parse_and_map().
I don't know why i detest __prefixing so much but I think it's really nasty.
Usually this is reserved for compiler- and linker related things, like __packed; or __init.
I would prefer irq_of_parse_and_map_strict() or something like that.
Yours, Linus Walleij
| |