Messages in this thread | | | Date | Mon, 23 Sep 2013 21:14:30 +0200 | Subject | Re: [PATCH 2/9] irqdomain: Introduce __irq_create_mapping() | From | Linus Walleij <> |
| |
On Mon, Sep 16, 2013 at 10:31 AM, Thierry Reding <thierry.reding@gmail.com> wrote:
> This is a version of irq_create_mapping() that propagates the precise > error code instead of returning 0 for all errors. It will be used in > subsequent patches to allow further propagation of error codes. > > To avoid code duplication, implement irq_create_mapping() as a wrapper > around the new __irq_create_mapping(). > > Signed-off-by: Thierry Reding <treding@nvidia.com>
Surprise! I don't like this.
I think it is better to first go over the call sites and make them all handle negative return numbers rather than pushing the obscure __interface.
I know from patch 0 that you think it's too much to change these 127 call sites but I don't think so, and I'm happy to merge one big patch changing all the 20 users in drivers/gpio.
Likewise with the 11 consumers in drivers/pinctrl.
It's just a a few archs+subsystems and it's just plain work.
So do that first.
Yours, Linus Walleij
| |