| Date | Fri, 4 Oct 2013 09:40:53 +0200 | From | Martin Schwidefsky <> | Subject | Re: [PATCH RFC 04/77] PCI/MSI/s390: Remove superfluous check of MSI type |
| |
On Wed, 2 Oct 2013 12:48:20 +0200 Alexander Gordeev <agordeev@redhat.com> wrote:
> arch_setup_msi_irqs() hook can only be called from the generic > MSI code which ensures correct MSI type parameter. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > --- > arch/s390/pci/pci.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c > index c79c6e4..61a3c2c 100644 > --- a/arch/s390/pci/pci.c > +++ b/arch/s390/pci/pci.c > @@ -425,8 +425,6 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) > int rc; > > pr_debug("%s: requesting %d MSI-X interrupts...", __func__, nvec); > - if (type != PCI_CAP_ID_MSIX && type != PCI_CAP_ID_MSI) > - return -EINVAL; > if (type == PCI_CAP_ID_MSI && nvec > 1) > return 1; > msi_vecs = min(nvec, ZPCI_MSI_VEC_MAX);
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
|