lkml.org 
[lkml]   [2013]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement code
    On Wed, Oct 02, 2013 at 12:49:06PM +0200, Alexander Gordeev wrote:
    >
    > + err = pci_msix_table_size(dev->pdev);
    > + if (err < 0)
    > + return err;
    > +
    > nvec = dev->caps.num_ports * num_online_cpus() + MLX5_EQ_VEC_COMP_BASE;
    > nvec = min_t(int, nvec, num_eqs);
    > + nvec = min_t(int, nvec, err);
    > if (nvec <= MLX5_EQ_VEC_COMP_BASE)
    > return -ENOSPC;

    Making sure we don't request more vectors then the device's is capable
    of -- looks good.
    >
    > @@ -131,20 +136,15 @@ static int mlx5_enable_msix(struct mlx5_core_dev *dev)
    > for (i = 0; i < nvec; i++)
    > table->msix_arr[i].entry = i;
    >
    > -retry:
    > - table->num_comp_vectors = nvec - MLX5_EQ_VEC_COMP_BASE;
    > err = pci_enable_msix(dev->pdev, table->msix_arr, nvec);
    > - if (err <= 0) {
    > + if (err) {
    > + kfree(table->msix_arr);
    > return err;
    > - } else if (err > MLX5_EQ_VEC_COMP_BASE) {
    > - nvec = err;
    > - goto retry;
    > }
    >

    According to latest sources, pci_enable_msix() may still fail so why
    do you want to remove this code?

    > - mlx5_core_dbg(dev, "received %d MSI vectors out of %d requested\n", err, nvec);
    > - kfree(table->msix_arr);
    > + table->num_comp_vectors = nvec - MLX5_EQ_VEC_COMP_BASE;
    >
    > - return -ENOSPC;
    > + return 0;
    > }
    >
    > static void mlx5_disable_msix(struct mlx5_core_dev *dev)
    > --
    > 1.7.7.6
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe netdev" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2013-10-03 09:41    [W:4.560 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site