| Date | Thu, 3 Oct 2013 22:12:05 +0200 | From | Alexander Gordeev <> | Subject | Re: [PATCH RFC 34/77] ioat: Update MSI/MSI-X interrupts enablement code |
| |
On Wed, Oct 02, 2013 at 11:00:51AM -0700, Williams, Dan J wrote: > I see patch 00/77 now and I still don't see the need for ioatdma to be > updated. If we fail the subsequent request_irq, the driver will still > fall back to trying less interrupts.
In the proposed design pci_enable_msix() will never return a positive value. Therefore if the driver is not updated it will fallback to single MSI if device->common.chancnt MSI-X vectors were not allocated while it used to fallback to a single MSI-X in the same situation. Not to mention 'if (err > 0)' dead code.
-- Regards, Alexander Gordeev agordeev@redhat.com
|