lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf kvm: Set name for VM process in guest machine
    Commit-ID:  5cd95c2db479aa7a66f6fa572dfa410c6314c78e
    Gitweb: http://git.kernel.org/tip/5cd95c2db479aa7a66f6fa572dfa410c6314c78e
    Author: David Ahern <dsahern@gmail.com>
    AuthorDate: Fri, 20 Jul 2012 17:25:47 -0600
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 25 Jul 2012 11:27:55 -0300

    perf kvm: Set name for VM process in guest machine

    COMM events are not generated in the context of a guest machine, so the
    thread name is never set for the VMM process. For example, the qemu-kvm
    name applies to the process in the host machine, not the guest machine.
    So, samples for guest machines are currently displayed as:

    99.67% :5671 [unknown] [g] 0xffffffff81366b41

    where 5671 is the pid of the VMM. With this patch the samples in the guest
    machine are shown as:

    18.43% [guest/5671] [unknown] [g] 0xffffffff810d68b7

    Tested-by: Jiri Olsa <jolsa@redhat.com>
    Signed-off-by: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/1342826756-64663-3-git-send-email-dsahern@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/map.c | 17 ++++++++++++++++-
    1 files changed, 16 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
    index a1f4e36..8668569 100644
    --- a/tools/perf/util/map.c
    +++ b/tools/perf/util/map.c
    @@ -7,6 +7,7 @@
    #include <stdio.h>
    #include <unistd.h>
    #include "map.h"
    +#include "thread.h"

    const char *map_type__name[MAP__NR_TYPES] = {
    [MAP__FUNCTION] = "Functions",
    @@ -585,7 +586,21 @@ int machine__init(struct machine *self, const char *root_dir, pid_t pid)
    self->kmaps.machine = self;
    self->pid = pid;
    self->root_dir = strdup(root_dir);
    - return self->root_dir == NULL ? -ENOMEM : 0;
    + if (self->root_dir == NULL)
    + return -ENOMEM;
    +
    + if (pid != HOST_KERNEL_ID) {
    + struct thread *thread = machine__findnew_thread(self, pid);
    + char comm[64];
    +
    + if (thread == NULL)
    + return -ENOMEM;
    +
    + snprintf(comm, sizeof(comm), "[guest/%d]", pid);
    + thread__set_comm(thread, comm);
    + }
    +
    + return 0;
    }

    static void dsos__delete(struct list_head *self)

    \
     
     \ /
      Last update: 2012-07-25 22:01    [W:0.027 / U:0.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site