lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] perf top: error handling for counter creation should parallel perf-record
Em Tue, Jul 24, 2012 at 08:01:38AM -0600, David Ahern escreveu:
> On 7/23/12 12:15 PM, Arnaldo Carvalho de Melo wrote:
> >Em Fri, Jul 20, 2012 at 05:25:54PM -0600, David Ahern escreveu:
> >>+ if ((err == ENOENT || err == ENXIO)
> >>+ && attr->type == PERF_TYPE_HARDWARE
> >>+ && attr->config == PERF_COUNT_HW_CPU_CYCLES) {

> >usual style:
> > if ((err == ENOENT || err == ENXIO) &&
> > attr->type == PERF_TYPE_HARDWARE &&
> > attr->config == PERF_COUNT_HW_CPU_CYCLES) {

> Right. I literally made it the same as builtin-record.c. I'll resubmit.

Ok, at some point we should fix that too, lowest prio tho, just trying
to avoid adding more.

- Arnaldo


\
 
 \ /
  Last update: 2012-07-24 17:21    [from the cache]
©2003-2011 Jasper Spaans