lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/11] perf kvm top: limit guest kernel info message to once
Em Tue, Jul 24, 2012 at 08:02:52AM -0600, David Ahern escreveu:
> On 7/23/12 12:17 PM, Arnaldo Carvalho de Melo wrote:
> >Em Fri, Jul 20, 2012 at 05:25:56PM -0600, David Ahern escreveu:
> >>+ static struct strlist *seen;
> >>+ char pidstr[8];

> >>+ if (!seen)
> >>+ seen = strlist__new(true, NULL);

> >>+ scnprintf(pidstr, sizeof(pidstr), "%d", event->ip.pid);
> >>+ if (!strlist__has_entry(seen, pidstr)) {
> >>+ pr_err("Can't find guest [%d]'s kernel information\n",
> >>+ event->ip.pid);
> >>+ strlist__add(seen, pidstr);

> >Abuse of strlist? Can't we have an intlist?
>
> Use of existing facility. :-) I'll look at adding an intlist facility.

Thanks!

- Arnaldo


\
 
 \ /
  Last update: 2012-07-24 17:21    [W:0.074 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site