Messages in this thread | | | Date | Tue, 24 Jul 2012 16:40:22 +0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 11/11] perf kvm top: limit guest kernel info message to once |
| |
Em Tue, Jul 24, 2012 at 08:02:52AM -0600, David Ahern escreveu: > On 7/23/12 12:17 PM, Arnaldo Carvalho de Melo wrote: > >Em Fri, Jul 20, 2012 at 05:25:56PM -0600, David Ahern escreveu: > >>+ static struct strlist *seen; > >>+ char pidstr[8];
> >>+ if (!seen) > >>+ seen = strlist__new(true, NULL);
> >>+ scnprintf(pidstr, sizeof(pidstr), "%d", event->ip.pid); > >>+ if (!strlist__has_entry(seen, pidstr)) { > >>+ pr_err("Can't find guest [%d]'s kernel information\n", > >>+ event->ip.pid); > >>+ strlist__add(seen, pidstr);
> >Abuse of strlist? Can't we have an intlist? > > Use of existing facility. :-) I'll look at adding an intlist facility.
Thanks!
- Arnaldo
| |