lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/16] perf evlist: Fix creation of cpu map
    Date
    From: Namhyung Kim <namhyung.kim@lge.com>

    Currently, 'perf record -- sleep 1' creates a cpu map for all online
    cpus since it turns out calling cpu_map__new(NULL). Fix it.

    Also it is guaranteed that cpu_list is NULL if PID/TID is given by
    calling perf_target__validate(), so we can make the conditional bit
    simpler.

    This also fixes perf test 7 (Validate) failure on my 6 core machine:

    $ cat /sys/devices/system/cpu/online
    0-11
    $ ./perf test -v 7
    7: Validate PERF_RECORD_* events & perf_sample fields:
    --- start ---
    perf_evlist__mmap: Operation not permitted
    ---- end ----
    Validate PERF_RECORD_* events & perf_sample fields: FAILED!

    Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
    Reviewed-by: David Ahern <dsahern@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1336367344-28071-3-git-send-email-namhyung.kim@lge.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/evlist.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
    index 3032862..183b199 100644
    --- a/tools/perf/util/evlist.c
    +++ b/tools/perf/util/evlist.c
    @@ -609,8 +609,9 @@ int perf_evlist__create_maps(struct perf_evlist *evlist,
    if (evlist->threads == NULL)
    return -1;

    - if (target->uid != UINT_MAX ||
    - (target->cpu_list == NULL && target->tid))
    + if (target->uid != UINT_MAX || target->tid)
    + evlist->cpus = cpu_map__dummy_new();
    + else if (!target->system_wide && target->cpu_list == NULL)
    evlist->cpus = cpu_map__dummy_new();
    else
    evlist->cpus = cpu_map__new(target->cpu_list);
    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-05-10 20:01    [W:0.024 / U:1.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site