lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/16] perf top: Set target.system_wide
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Check if neither of --pid, --tid or --uid was specified and if so, set
    system_wide appropriately.

    Namhyung's patch would make using any of the above target specifiers
    emit a warning in perf_target__validate, since it would see
    target.system_wide set and one of the others as well.

    So set system_wide after validation.

    Suggested-by: David Ahern <dsahern@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-6e4zrji1uw0rinfyoitl0wi4@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-top.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 2a0ec09..e40f86e 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -1258,6 +1258,10 @@ int cmd_top(int argc, const char **argv, const char *prefix __used)
    if (top.target.uid_str != NULL && top.target.uid == UINT_MAX - 1)
    goto out_delete_evlist;

    + if (top.target.tid == 0 && top.target.pid == 0 &&
    + top.target.uid_str == NULL)
    + top.target.system_wide = true;
    +
    if (perf_evlist__create_maps(top.evlist, &top.target) < 0)
    usage_with_options(top_usage, options);

    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-05-10 20:01    [W:0.024 / U:118.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site