[lkml]   [2012]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: ehci dynamic debug problem
    On Fri, 13 Apr 2012, Johannes Stezenbach wrote:

    > > > Does it make sense now?
    > >
    > > No. What happens if dynamic debug is enabled for one line that calls
    > > dbg_port_buf() but not for another? There's no way to avoid the string
    > > formatting in both lines, even though one of them discards the result.
    > That's why I said in my initial mail:
    > Does dynamic debug offer an "is the message two lines below enabled" test?
    > What I meant is that dbg_port() could test if it
    > needs to call dbg_port_buf() for this call site.

    Oh. As far as I know, that's not possible.

    > Anyway, maybe the dbg_*_buf() are not called often enough to worry?

    Probably not.

    > If you're OK with "#if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)"
    > then maybe you should just do that?

    Yes, that sounds best.

    Alan Stern

     \ /
      Last update: 2012-04-13 21:43    [W:0.018 / U:2.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site