Messages in this thread | | | Date | Mon, 16 Apr 2012 13:15:46 -0400 | From | Jason Baron <> | Subject | Re: ehci dynamic debug problem |
| |
On Mon, Apr 16, 2012 at 06:41:39PM +0200, Johannes Stezenbach wrote: > On Mon, Apr 16, 2012 at 11:54:24AM -0400, Jason Baron wrote: > > On Fri, Apr 13, 2012 at 09:03:11PM +0200, Johannes Stezenbach wrote: > > > > > > Does dynamic debug offer an "is the message two lines below enabled" test? > > > > > > > Sorry was away for a bit... > > > > dynamic debug doesn't offer any is enabled test, its hidden from the > > user. That said, in this case, you can delay the printing to the buffer > > with: > ... > > + ehci_dbg (ehci, "%s\n", dbg_port_buf (_buf, sizeof _buf, label, port, status)); \ > > I think arguments are evaluated before dev_dbg is called so this > won't help. > >
I looked at the disassembly - and this argument was in fact *not* evaluated before the call. So I think this approach is worthwhile.
Thanks,
-Jason
| |