[lkml]   [2012]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/1] leds: Add LED driver for lm3556 chip
    On Fri, Mar 30, 2012 at 08:56:34PM +0200, Wolfram Sang wrote:
    > On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:

    > > +EXPORT_SYMBOL_GPL(lm3556_write_bits);

    > Seeing all these functions it may be worth converting to REGMAP.
    > Then you already have regmap_update_bits and the like.

    Plus cache and debug infrastructure if that's useful.

    > > +static ssize_t lm3556_indicator_pattern_store(struct device *dev,
    > > + struct device_attribute *devAttr,
    > > + const char *buf, size_t size)

    > > +static DEVICE_ATTR(pattern, 0644, NULL, lm3556_indicator_pattern_store);

    > I don't know the LED subsytsem very well. Is it that specific to the chip so we
    > need a DEVICE_ATTR? Or can this be generalized in the core?

    Alternatively some documentation indicating what the userspace ABI is
    might help someone identify if there's a relevant feature more easily :)
    If it's periodic blinking then there's definitely a core feature for

    > > + chip = kzalloc(sizeof(struct lm3556_chip_data), GFP_KERNEL);


     \ /
      Last update: 2012-03-31 23:13    [W:0.020 / U:4.984 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site