lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] leds: Add LED driver for lm3556 chip
On Sat, 31 Mar 2012 21:37:23 -0600
Shuah Khan <shuahkhan@gmail.com> wrote:

> > + ret = kstrtoul(buf, 10, &state);
> > + if (ret)
> > + goto out;
> > if (isspace(*after))
> > count++;
>
> after is used without initialization. Please note that simple_strtoul()
> initializes after. Don't think this will work.

I didn't try very hard ;)

I think I'll drop the whole patch. According to my notes,

- Wolfram's comments should be addressed
- Move the header file out of include/linux/
- Consider using the regmap API


\
 
 \ /
  Last update: 2012-04-07 01:31    [W:0.043 / U:0.888 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site