lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] leds: Add LED driver for lm3556 chip
On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:
> It is a simple driver for LM3556 Chip(Texas Instruments)
> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white LED.
> Datasheet: www.national.com/ds/LM/LM3556.pdf
>
> Tested on OMAP4430
>
> Signed-off-by: Geon Si Jeong <gshark.jeong@gmail.com>
> ---
> drivers/leds/Kconfig | 9 +
> drivers/leds/Makefile | 2 +-
> drivers/leds/leds-lm3556.c | 462 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/leds-lm3556.h | 242 ++++++++++++++++++++++

Why does this .h file have to be in include/linux/ ?

Why does it need to be a .h file at all? Why can't it be part of the .c
file?

Only put files in include/linux/ that other files outside of your local
directory, need to access, and only put stuff in those files that other
files need to have.

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-04-04 00:13    [W:0.079 / U:2.284 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site